Add support to detect prefixed JAVA_HOME_ env variables for installation#758
Merged
akurtakov merged 2 commits intoeclipse-jdt:masterfrom Sep 1, 2025
Merged
Conversation
The setup-java github actions defines by default java installations in env variable starting with JAVA_HOME_ but this is currently not detected. This now additionally also supports this form of JVM installs and fixes an issue with relying on toSet returning a modifiable set (what is not guaranteed).
8f5c0f4 to
9b0ac16
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup-java github actions defines by default java installations in env variable starting with JAVA_HOME_ but this is currently not detected.
This now additionally also supports this form of JVM installs and fixes an issue with relying on toSet returning a modifiable set (what is not guaranteed).
What it does
How to test
Author checklist